Paths

Table of Contentst

Differential D13572

Allow PhutilClassMapQuery to filter null
ClosedPublic
Actions

Authored by joshuaspence on Jul 7 2015, 10:02 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU80ea20a45055: Allow PhutilClassMapQuery to filter null

Summary

Allow PhutilClassMapQuery to filter objects which return null from the "unique" method.

Test Plan

See next diff.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7175
Build 7395: [Placeholder Plan] Wait for 30 Seconds
Build 7394: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32798.Jul 7 2015, 10:02 AM

joshuaspence retitled this revision from to Allow PhutilClassMapQuery to filter null.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 7 2015, 10:02 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

joshuaspence added a child revision: D13573: Use PhutilClassMapQuery instead of PhutilSymbolLoader.Jul 7 2015, 10:08 AM

epriestley accepted this revision.Jul 7 2015, 12:36 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/symbols/PhutilClassMapQuery.php
79–81	Prefer documenting.

This revision is now accepted and ready to land.Jul 7 2015, 12:36 PM

FWIW, I find the method signature pretty awkward, but it seemed better than adding a filterNull() method.

I think it's OK. Not ideal, but does seem cleaner than a separate method.

And likewise cleaner than a setUniqueButAlsoNullFitleringMethod(...) method.

Add docs

Set default value

Closed by commit rPHU80ea20a45055: Allow PhutilClassMapQuery to filter null (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 7 2015, 12:52 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D13599: Update cache key for class map query.Jul 8 2015, 10:14 AM

joshuaspence mentioned this in rPHUaa6cd8f7e5e5: Update cache key for class map query.Jul 8 2015, 10:22 AM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

symbols/

PhutilClassMapQuery.php

13 lines

Diff 32805

View Options

src/symbols/PhutilClassMapQuery.php

Allow PhutilClassMapQuery to filter nullClosedPublicActions