Page MenuHomePhabricator

Allow PhutilClassMapQuery to filter null
ClosedPublic

Authored by joshuaspence on Jul 7 2015, 10:02 AM.

Details

Summary

Allow PhutilClassMapQuery to filter objects which return null from the "unique" method.

Test Plan

See next diff.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7175
Build 7395: [Placeholder Plan] Wait for 30 Seconds
Build 7394: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Allow PhutilClassMapQuery to filter null.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/symbols/PhutilClassMapQuery.php
79–81

Prefer documenting.

This revision is now accepted and ready to land.Jul 7 2015, 12:36 PM

FWIW, I find the method signature pretty awkward, but it seemed better than adding a filterNull() method.

I think it's OK. Not ideal, but does seem cleaner than a separate method.

And likewise cleaner than a setUniqueButAlsoNullFitleringMethod(...) method.

This revision was automatically updated to reflect the committed changes.