Page MenuHomePhabricator
Differential D13572

Allow PhutilClassMapQuery to filter null
ClosedPublic
Actions

Authored by joshuaspence on Jul 7 2015, 10:02 AM.
Tags
None
Referenced Files
F13098441: D13572.id.diff
Fri, Apr 26, 6:52 AM
Unknown Object (File)
Fri, Apr 26, 1:14 AM
Unknown Object (File)
Thu, Apr 25, 1:36 PM
Unknown Object (File)
Thu, Apr 25, 2:36 AM
Unknown Object (File)
Wed, Apr 24, 11:17 PM
Unknown Object (File)
Tue, Apr 23, 8:41 AM
Unknown Object (File)
Fri, Apr 19, 5:32 AM
Unknown Object (File)
Mon, Apr 8, 1:48 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU80ea20a45055: Allow PhutilClassMapQuery to filter null
Summary

Allow PhutilClassMapQuery to filter objects which return null from the "unique" method.

Test Plan

See next diff.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32798.Jul 7 2015, 10:02 AM
joshuaspence retitled this revision from to Allow PhutilClassMapQuery to filter null.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 7 2015, 10:02 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence added a child revision: D13573: Use PhutilClassMapQuery instead of PhutilSymbolLoader.Jul 7 2015, 10:08 AM
epriestley accepted this revision.Jul 7 2015, 12:36 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/symbols/PhutilClassMapQuery.php
79–81

Prefer documenting.

This revision is now accepted and ready to land.Jul 7 2015, 12:36 PM
joshuaspence added a comment.Jul 7 2015, 12:38 PM

FWIW, I find the method signature pretty awkward, but it seemed better than adding a filterNull() method.

epriestley added a comment.Jul 7 2015, 12:42 PM

I think it's OK. Not ideal, but does seem cleaner than a separate method.

epriestley added a comment.Jul 7 2015, 12:42 PM

And likewise cleaner than a setUniqueButAlsoNullFitleringMethod(...) method.

joshuaspence updated this revision to Diff 32805.Jul 7 2015, 12:50 PM
joshuaspence edited edge metadata.

Add docs

joshuaspence updated this revision to Diff 32806.Jul 7 2015, 12:51 PM

Set default value

Closed by commit rPHU80ea20a45055: Allow PhutilClassMapQuery to filter null (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 7 2015, 12:52 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D13599: Update cache key for class map query.Jul 8 2015, 10:14 AM
joshuaspence mentioned this in rPHUaa6cd8f7e5e5: Update cache key for class map query.Jul 8 2015, 10:22 AM

Revision Contents
Changeset List

PathSize
src/
symbols/
13 lines

Diff 32807

View Options

src/symbols/PhutilClassMapQuery.php

Loading...
Phabricator · Built by Phacility