Page MenuHomePhabricator

[Redesign] Update Object Selector UI
ClosedPublic

Authored by chad on Jul 2 2015, 2:48 AM.
Tags
None
Referenced Files
F12829417: D13524.id32713.diff
Thu, Mar 28, 11:30 AM
Unknown Object (File)
Feb 16 2024, 3:11 PM
Unknown Object (File)
Feb 9 2024, 11:00 AM
Unknown Object (File)
Feb 9 2024, 10:22 AM
Unknown Object (File)
Feb 3 2024, 5:38 AM
Unknown Object (File)
Jan 30 2024, 9:24 AM
Unknown Object (File)
Jan 19 2024, 12:17 AM
Unknown Object (File)
Jan 17 2024, 8:00 PM
Subscribers

Details

Summary

Ref T8099, Better colors and spacing on the Object Selector.

Test Plan

Hover and test new spacing.

Diff Detail

Repository
rP Phabricator
Branch
obj-selector
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7107
Build 7266: [Placeholder Plan] Wait for 30 Seconds
Build 7265: arc lint + arc unit

Event Timeline

chad retitled this revision from to [Redesign] Update Object Selector UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 2 2015, 9:24 PM

@epriestley, I somehow detached this change from my spaces branch. Any easy way to land it?

git checkout master
git pull
arc patch D13524
arc land

(maybe)

I don't want to land it on master, and rebasing to redesign makes me apply every commit/patch. I can send it up as a new diff instead. Just didnt know if there was a better way.

Maybe:

$ git checkout redesign-2015
$ git checkout -b temporary
$ git cherry-pick obj-selector
$ arc land --onto redesign-2015
This revision was automatically updated to reflect the committed changes.