Page MenuHomePhabricator

[Redesign] Update Object Selector UI
ClosedPublic

Authored by chad on Jul 2 2015, 2:48 AM.

Details

Summary

Ref T8099, Better colors and spacing on the Object Selector.

Test Plan

Hover and test new spacing.

Diff Detail

Repository
rP Phabricator
Branch
obj-selector
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7107
Build 7266: [Placeholder Plan] Wait for 30 Seconds
Build 7265: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32692.Jul 2 2015, 2:48 AM
chad retitled this revision from to [Redesign] Update Object Selector UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley accepted this revision.Jul 2 2015, 9:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 2 2015, 9:24 PM
chad added a comment.Jul 2 2015, 9:28 PM

@epriestley, I somehow detached this change from my spaces branch. Any easy way to land it?

btrahan edited edge metadata.Jul 2 2015, 9:29 PM

git checkout master
git pull
arc patch D13524
arc land

(maybe)

chad added a comment.Jul 2 2015, 9:33 PM

I don't want to land it on master, and rebasing to redesign makes me apply every commit/patch. I can send it up as a new diff instead. Just didnt know if there was a better way.

Maybe:

$ git checkout redesign-2015
$ git checkout -b temporary
$ git cherry-pick obj-selector
$ arc land --onto redesign-2015
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jul 2 2015, 9:47 PM

thx u :3 😄