[Redesign] Update Object Selector UI
ClosedPublic
Actions

Authored by chad on Jul 2 2015, 2:48 AM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rP233144e29993: [Redesign] Update Object Selector UI

Summary

Ref T8099, Better colors and spacing on the Object Selector.

Test Plan

Hover and test new spacing.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 32692.Jul 2 2015, 2:48 AM

chad retitled this revision from to [Redesign] Update Object Selector UI.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 2 2015, 2:48 AM

epriestley accepted this revision.Jul 2 2015, 9:24 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 2 2015, 9:24 PM

@epriestley, I somehow detached this change from my spaces branch. Any easy way to land it?

git checkout master
git pull
arc patch D13524
arc land

(maybe)

I don't want to land it on master, and rebasing to redesign makes me apply every commit/patch. I can send it up as a new diff instead. Just didnt know if there was a better way.

Maybe:

$ git checkout redesign-2015
$ git checkout -b temporary
$ git cherry-pick obj-selector
$ arc land --onto redesign-2015

Closed by commit rP233144e29993: [Redesign] Update Object Selector UI (authored by chad, committed by chad). · Explain WhyJul 2 2015, 9:39 PM

This revision was automatically updated to reflect the committed changes.

thx u :3 😄

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

css/

application/

objectselector/

object-selector.css

25 lines

Diff 32713

View Options

resources/celerity/map.php