This maybe fixes T8576. Whilst running ./bin/search index --all I noticed that I ended up with 159,596 temporary directory which I believe are due to phutil_console_get_terminal_width() running too often.
Details
Details
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Technically, we should listen for SIGWINCH (I think) and dirty this cache (because the user may resize the console while running the command), but this behavior is clearly worlds better than the prior behavior.
Comment Actions
Possibly we should do some false vs null stuff so that we cache "it didn't work", too, but whatevs.