Remove vestigal "tags" stuff from Herald
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 11:04 PM.

Tags

None

Referenced Files

	F14372485: D13498.diff
	Fri, Dec 20, 7:53 PM

	F14361929: D13498.id32653.diff
	Fri, Dec 20, 12:10 PM

	Unknown Object (File)
	Thu, Dec 19, 12:46 AM

	Unknown Object (File)
	Thu, Dec 12, 1:47 PM

	Unknown Object (File)
	Wed, Dec 11, 8:30 AM

	Unknown Object (File)
	Tue, Dec 3, 9:42 PM

	Unknown Object (File)
	Wed, Nov 27, 6:28 PM

	Unknown Object (File)
	Thu, Nov 21, 1:02 PM

View All Files

Subscribers

eadler

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T8726: Modularize Herald fields and actions

Commits

Restricted Diffusion Commit
rPbfbc0e638ddf: Remove vestigal "tags" stuff from Herald

Summary

Ref T8726. No clue what this was.

Test Plan

Grepped for usage, found none.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32653.Jun 30 2015, 11:04 PM

epriestley retitled this revision from to Remove vestigal "tags" stuff from Herald.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8726: Modularize Herald fields and actions.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 11:04 PM

probably something that once worked at FB is my guess...

This revision is now accepted and ready to land.Jul 1 2015, 5:01 PM

eadler added a subscriber: eadler.Jul 3 2015, 7:48 PM

Closed by commit rPbfbc0e638ddf: Remove vestigal "tags" stuff from Herald (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 8:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

6 lines

Diff 32781

View Options

src/applications/herald/adapter/HeraldAdapter.php

Remove vestigal "tags" stuff from HeraldClosedPublicActions