Differential D13498

Remove vestigal "tags" stuff from Herald
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 11:04 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8726: Modularize Herald fields and actions

Commits

Restricted Diffusion Commit
rPbfbc0e638ddf: Remove vestigal "tags" stuff from Herald

Summary

Ref T8726. No clue what this was.

Test Plan

Grepped for usage, found none.

Diff Detail

Repository

rP Phabricator

Branch

hmodular4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7077
Build 7206: [Placeholder Plan] Wait for 30 Seconds
Build 7205: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32653.Jun 30 2015, 11:04 PM

epriestley retitled this revision from to Remove vestigal "tags" stuff from Herald.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8726: Modularize Herald fields and actions.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 11:04 PM

probably something that once worked at FB is my guess...

This revision is now accepted and ready to land.Jul 1 2015, 5:01 PM

eadler added a subscriber: eadler.Jul 3 2015, 7:48 PM

Closed by commit rPbfbc0e638ddf: Remove vestigal "tags" stuff from Herald (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 8:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

6 lines

Diff 32653

View Options

src/applications/herald/adapter/HeraldAdapter.php

Remove vestigal "tags" stuff from HeraldClosedPublicActions