Page MenuHomePhabricator
Differential D13495

Modularize more Herald fields
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 10:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 13, 2:12 AM
Unknown Object (File)
Mon, Jan 6, 4:34 AM
Unknown Object (File)
Fri, Dec 20, 12:10 PM
Unknown Object (File)
Dec 15 2024, 6:37 PM
Unknown Object (File)
Dec 11 2024, 11:51 PM
Unknown Object (File)
Dec 8 2024, 6:24 PM
Unknown Object (File)
Dec 5 2024, 11:18 AM
Unknown Object (File)
Dec 5 2024, 7:14 AM
View All Files
Subscribers
eadler
epriestley
joshuaspence

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP59c294457f71: Modularize more Herald fields
Summary

Ref T8726. Continue making Herald fields more modular than they currently are.

Test Plan
  • Created a rule using all the affected fields.
  • Ran the rule.
  • Saw reasonable object field values.

Diff Detail

Repository
rP Phabricator
Branch
hmodular2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7073
Build 7199: [Placeholder Plan] Wait for 30 Seconds
Build 7198: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32649.Jun 30 2015, 10:38 PM
epriestley retitled this revision from to Modularize more Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 10:38 PM
joshuaspence added a subscriber: joshuaspence.Jul 1 2015, 2:31 AM
btrahan accepted this revision.Jul 1 2015, 5:00 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:00 PM
eadler added a subscriber: eadler.Jul 3 2015, 7:49 PM
Closed by commit rP59c294457f71: Modularize more Herald fields (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 8:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32649

View Options

resources/sql/autopatches/20140210.herald.rule-condition-mig.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldDifferentialDiffAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldPholioMockAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptController.php

Loading...
View Options

src/applications/herald/field/HeraldAlwaysField.php

Loading...
View Options

src/applications/herald/field/HeraldAnotherRuleField.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
View Options

src/applications/herald/field/HeraldNewObjectField.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

Loading...
View Options

src/applications/project/herald/HeraldProjectsField.php

Loading...
View Options

src/applications/spaces/herald/HeraldSpaceField.php

Loading...
View Options

src/applications/subscriptions/herald/HeraldSubscribersField.php

Loading...
Phabricator · Built by Phacility