Page MenuHomePhabricator

Modularize more Herald fields
ClosedPublic

Authored by epriestley on Jun 30 2015, 10:38 PM.
Tags
None
Referenced Files
F18759609: D13495.id32779.diff
Mon, Oct 6, 4:43 AM
F18683817: D13495.diff
Fri, Sep 26, 8:22 AM
F18645483: D13495.id32649.diff
Fri, Sep 19, 7:57 AM
F18603400: D13495.diff
Sep 13 2025, 5:03 PM
F18586373: D13495.id.diff
Sep 11 2025, 6:23 PM
F18567999: D13495.id32779.diff
Sep 9 2025, 9:47 PM
F18567998: D13495.id32649.diff
Sep 9 2025, 9:47 PM
F18506072: D13495.id.diff
Sep 5 2025, 1:10 AM

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP59c294457f71: Modularize more Herald fields
Summary

Ref T8726. Continue making Herald fields more modular than they currently are.

Test Plan
  • Created a rule using all the affected fields.
  • Ran the rule.
  • Saw reasonable object field values.

Diff Detail

Repository
rP Phabricator
Branch
hmodular2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7073
Build 7199: [Placeholder Plan] Wait for 30 Seconds
Build 7198: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize more Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:00 PM
This revision was automatically updated to reflect the committed changes.