Page MenuHomePhabricator
Differential D13488

Begin modularizing Herald fields
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 5:33 PM.
Tags
None
Referenced Files
F14371876: D13488.diff
Fri, Dec 20, 7:22 PM
F14361911: D13488.id32631.diff
Fri, Dec 20, 12:09 PM
Unknown Object (File)
Sat, Dec 14, 2:42 AM
Unknown Object (File)
Fri, Dec 13, 2:20 PM
Unknown Object (File)
Sun, Dec 8, 12:32 PM
Unknown Object (File)
Mon, Dec 2, 8:31 PM
Unknown Object (File)
Wed, Nov 27, 5:29 PM
Unknown Object (File)
Wed, Nov 27, 1:12 AM
View All Files
Subscribers
eadler
epriestley
joshuaspence
Tokens
"Piece of Eight" token, awarded by joshuaspence.

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rPb266412f3ee8: Begin modularizing Herald fields
Summary

Ref T8726. This lays groundwork for modularizing Herald fields and modularizes the "Content source" field.

This doesn't touch conditions or values yet.

Test Plan

Created a rule with a "content source" field, created a new task, saw rule apply.

Diff Detail

Repository
rP Phabricator
Branch
hmodular1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7065
Build 7183: [Placeholder Plan] Wait for 30 Seconds
Build 7182: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32631.Jun 30 2015, 5:33 PM
epriestley retitled this revision from to Begin modularizing Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 5:33 PM
btrahan accepted this revision.Jun 30 2015, 6:22 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 6:22 PM
joshuaspence awarded a token.Jun 30 2015, 8:51 PM
joshuaspence added a subscriber: joshuaspence.
eadler added a subscriber: eadler.Jul 3 2015, 7:49 PM
Closed by commit rPb266412f3ee8: Begin modularizing Herald fields (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 8:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
herald/
adapter/
81 lines
1 line
field/
30 lines
60 lines

Diff 32631

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/field/HeraldContentSourceField.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
Phabricator · Built by Phacility