Fix type spec for 'coverage'
ClosedPublic
Actions

Authored by epriestley on Jun 25 2015, 1:53 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T8670: Harbormaster autoplan targets do not always complete

Commits

Restricted Diffusion Commit
rP5f99d79c5d17: Fix type spec for 'coverage'

Summary

Ref T8670. The spec for "coverage" is incorrect, it's a map of paths to coverage information.

Test Plan

See next diff.

Diff Detail

Repository

rP Phabricator

Branch

cov1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7004
Build 7063: [Placeholder Plan] Wait for 30 Seconds
Build 7062: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32522.Jun 25 2015, 1:53 PM

epriestley retitled this revision from to Fix type spec for 'coverage'.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

epriestley added a task: T8670: Harbormaster autoplan targets do not always complete.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 25 2015, 1:53 PM

epriestley mentioned this in T8670: Harbormaster autoplan targets do not always complete.Jun 25 2015, 2:03 PM

btrahan accepted this revision.Jun 25 2015, 5:02 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 25 2015, 5:02 PM

Closed by commit rP5f99d79c5d17: Fix type spec for 'coverage' (authored by epriestley, committed by epriestley). · Explain WhyJun 25 2015, 5:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuildUnitMessage.php

2 lines

Diff 32522

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php

Fix type spec for 'coverage'ClosedPublicActions