Page MenuHomePhabricator
Differential D13338

Fix arcanist shell completion
ClosedPublic
Actions

Authored by joshuaspence on Jun 18 2015, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 12:44 PM
Unknown Object (File)
Fri, Dec 20, 9:21 PM
Unknown Object (File)
Tue, Dec 17, 12:08 AM
Unknown Object (File)
Mon, Dec 16, 11:59 AM
Unknown Object (File)
Thu, Dec 12, 2:50 AM
Unknown Object (File)
Wed, Dec 11, 2:12 PM
Unknown Object (File)
Sun, Dec 8, 12:34 PM
Unknown Object (File)
Sun, Dec 8, 12:59 AM
View All Files
Subscribers
avivey
epriestley
Korvin

Details

Reviewers
epriestley
avivey
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8560: arc shell-complete gives error when out of workspace
Commits
rARCf06eea0d8484: Fix arcanist shell completion
Summary

Fixes T8560.

Test Plan

Ran arc shell-complete outside of a working copy.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32273.Jun 18 2015, 2:06 PM
joshuaspence retitled this revision from to Fix arcanist shell completion.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T8560: arc shell-complete gives error when out of workspace.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2015, 2:07 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
avivey accepted this revision.Jun 18 2015, 5:41 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

It'a a little early for me to really dig in, but I do arc fl<tab> --<tab><tab> and get the list of flags for flag, so it's probably good.

epriestley accepted this revision.Jun 19 2015, 12:18 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 19 2015, 12:18 AM
Closed by commit rARCf06eea0d8484: Fix arcanist shell completion (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 19 2015, 3:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32308

View Options

src/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility