Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4558: Make Diviner useful for third-parties
- Commits
- Restricted Diffusion Commit
rP9921cbc41ac3: Allow atoms to be queried by book
Poked around at /diviner/query/.
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 6793 Build 6815: [Placeholder Plan] Wait for 30 Seconds
Time | Test | |
---|---|---|
204 ms | PhabricatorCelerityTestCase::testCelerityMaps | |
8 ms | PhabricatorConduitTestCase::testConduitMethods | |
0 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled | |
4 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries | |
12 ms | PhabricatorLibraryTestCase::testEverythingImplemented | |
View Full Test Results (1 Failed · 6 Passed) |
Event Timeline
src/applications/diviner/markup/DivinerSymbolRemarkupRule.php | ||
---|---|---|
117–121 ↗ | (On Diff #32187) | I think we're generally better off not doing this, and that preserving git blame / having smaller diffs is more valuable on the balance than having statements aligned. In a perfect world, git blame would ignore these changes (maybe as arc blame), and Differential would be smart enough to tell that you were only doing an alignment change, even though you were changing intraline whitespace, and ignore it. But I don't expect us to get there for a long time. (In this specific case 'book' is not correctly aligned.) |
src/applications/diviner/query/DivinerBookQuery.php | ||
146 | This is maybe a little confusing because name can be zebrafacts ("Z") and the title can be A Collection of Fine Facts about Zebras ("A" or "C", depending on how smart we want to be), which puts the book at totally separate ends of the list. Ideally we would probably define a sortableTitle column, strip common articles ("A", "An", "The") in some central algorithm, dump the rest of the title in there in a normalized form, then sort by that. This can happen some time far in the future, though. |