Page MenuHomePhabricator

Allow atoms to be queried by book

Authored by joshuaspence on Jun 16 2015, 10:20 AM.


Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4558: Make Diviner useful for third-parties
Restricted Diffusion Commit
rP9921cbc41ac3: Allow atoms to be queried by book

Ref T4558. Allows querying for atoms from specified books. Depends on D13091.

Test Plan

Poked around at /diviner/query/.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence retitled this revision from to Allow atoms to be queried by book.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D13091: Modernize Diviner.
joshuaspence edited edge metadata.

Minor tidying

epriestley accepted this revision.Jun 16 2015, 1:58 PM
epriestley edited edge metadata.
epriestley added inline comments.
117–121 ↗(On Diff #32187)

I think we're generally better off not doing this, and that preserving git blame / having smaller diffs is more valuable on the balance than having statements aligned.

In a perfect world, git blame would ignore these changes (maybe as arc blame), and Differential would be smart enough to tell that you were only doing an alignment change, even though you were changing intraline whitespace, and ignore it. But I don't expect us to get there for a long time.

(In this specific case 'book' is not correctly aligned.)


This is maybe a little confusing because name can be zebrafacts ("Z") and the title can be A Collection of Fine Facts about Zebras ("A" or "C", depending on how smart we want to be), which puts the book at totally separate ends of the list.

Ideally we would probably define a sortableTitle column, strip common articles ("A", "An", "The") in some central algorithm, dump the rest of the title in there in a normalized form, then sort by that.

This can happen some time far in the future, though.

This revision is now accepted and ready to land.Jun 16 2015, 1:58 PM
joshuaspence edited edge metadata.


This revision was automatically updated to reflect the committed changes.