Differential D13239

Don't require users be activated in order to establish Web sessions
ClosedPublic
Actions

Authored by epriestley on Jun 10 2015, 8:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 8:32 AM

	Unknown Object (File)
	Mon, Apr 1, 6:42 AM

	Unknown Object (File)
	Sun, Mar 31, 5:55 PM

	Unknown Object (File)
	Sat, Mar 30, 3:09 AM

	Unknown Object (File)
	Sat, Mar 30, 3:06 AM

	Unknown Object (File)
	Sat, Mar 30, 3:06 AM

	Unknown Object (File)
	Thu, Mar 28, 5:25 AM

	Unknown Object (File)
	Wed, Mar 20, 10:04 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages

Commits

Restricted Diffusion Commit
rP8d6209b70113: Don't require users be activated in order to establish Web sessions

Summary

Ref T8496. In D13123, the condition for establishing a web session was made too strict: we need to let non-activated users establish web sessions in order to see "you are a bad disabled person" or "your account needs approval" messages. The previous behavior let them in, the new behavior incorrectly locks them out.

Test Plan

Enabled login approvals and registered a new account with username/password auth.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31999.Jun 10 2015, 8:24 PM

epriestley retitled this revision from to Don't require users be activated in order to establish Web sessions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 10 2015, 8:24 PM

epriestley mentioned this in T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.Jun 10 2015, 8:29 PM

This probably fixesT8454 as well.

btrahan accepted this revision.Jun 10 2015, 10:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 10 2015, 10:33 PM

Closed by commit rP8d6209b70113: Don't require users be activated in order to establish Web sessions (authored by epriestley, committed by epriestley). · Explain WhyJun 10 2015, 10:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

storage/

PhabricatorUser.php

4 lines

Diff 32008

src/applications/people/storage/PhabricatorUser.php

Loading...