Fixes T8433. Add an index to the phabricator_feed.feed_storynotification table. Primarily, this speeds up object destruction.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8433: Destroying a Diviner book is very slow
- Commits
- Restricted Diffusion Commit
rP7eac4865abd0: Add an index to the story notification table
Ran ./bin/storage upgrade and saw the migration apply cleanly.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6614 Build 6636: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
It's sufficient to just change the .php file without actually adding a migration, too, if you want: we'll add the key automatically.
(After storage adjust first came out I didn't want to put too much faith in it and kept specifying keys, but it seems stable and I'm more comfortable about letting it do more work now, so I've been gradually specifying fewer keys in actual .sql files.)