Page MenuHomePhabricator

Add an index to the story notification table
ClosedPublic

Authored by joshuaspence on Jun 5 2015, 7:51 AM.
Tags
None
Referenced Files
F12827282: D13164.id31896.diff
Thu, Mar 28, 9:54 AM
Unknown Object (File)
Mon, Mar 25, 5:41 PM
Unknown Object (File)
Mon, Mar 25, 5:37 PM
Unknown Object (File)
Feb 15 2024, 12:53 PM
Unknown Object (File)
Feb 9 2024, 4:23 PM
Unknown Object (File)
Feb 3 2024, 4:44 AM
Unknown Object (File)
Dec 29 2023, 11:09 AM
Unknown Object (File)
Dec 27 2023, 9:49 AM
Subscribers

Details

Summary

Fixes T8433. Add an index to the phabricator_feed.feed_storynotification table. Primarily, this speeds up object destruction.

Test Plan

Ran ./bin/storage upgrade and saw the migration apply cleanly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add an index to the story notification table.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

It's sufficient to just change the .php file without actually adding a migration, too, if you want: we'll add the key automatically.

(After storage adjust first came out I didn't want to put too much faith in it and kept specifying keys, but it seems stable and I'm more comfortable about letting it do more work now, so I've been gradually specifying fewer keys in actual .sql files.)

This revision is now accepted and ready to land.Jun 7 2015, 1:51 PM
joshuaspence edited edge metadata.

Allow ./bin/storage adjust to work its magic

This revision was automatically updated to reflect the committed changes.