Paths

Table of Contentst

Differential D13164

Add an index to the story notification table
ClosedPublic
Actions

Authored by joshuaspence on Jun 5 2015, 7:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 13, 5:41 PM

	Unknown Object (File)
	Tue, Jan 7, 5:19 AM

	Unknown Object (File)
	Fri, Jan 3, 10:34 PM

	Unknown Object (File)
	Wed, Dec 25, 5:03 PM

	Unknown Object (File)
	Dec 15 2024, 9:49 AM

	Unknown Object (File)
	Dec 11 2024, 8:42 PM

	Unknown Object (File)
	Dec 2 2024, 12:01 PM

	Unknown Object (File)
	Dec 1 2024, 1:38 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8433: Destroying a Diviner book is very slow

Commits

Restricted Diffusion Commit
rP7eac4865abd0: Add an index to the story notification table

Summary

Fixes T8433. Add an index to the phabricator_feed.feed_storynotification table. Primarily, this speeds up object destruction.

Test Plan

Ran ./bin/storage upgrade and saw the migration apply cleanly.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31818.Jun 5 2015, 7:51 AM

joshuaspence retitled this revision from to Add an index to the story notification table.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8433: Destroying a Diviner book is very slow.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 5 2015, 7:51 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

It's sufficient to just change the .php file without actually adding a migration, too, if you want: we'll add the key automatically.

(After storage adjust first came out I didn't want to put too much faith in it and kept specifying keys, but it seems stable and I'm more comfortable about letting it do more work now, so I've been gradually specifying fewer keys in actual .sql files.)

This revision is now accepted and ready to land.Jun 7 2015, 1:51 PM

Allow ./bin/storage adjust to work its magic

Closed by commit rP7eac4865abd0: Add an index to the story notification table (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 8 2015, 1:30 AM

This revision was automatically updated to reflect the committed changes.

jhurwitz mentioned this in T8455: Herald rules with mailing lists are broken after mailing list -> user migration.Jun 8 2015, 6:31 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

notification/

storage/

PhabricatorFeedStoryNotification.php

3 lines

Diff 31896

src/applications/notification/storage/PhabricatorFeedStoryNotification.php

Loading...