Currently, arcanist error output is sent to STDOUT instead of STDOUT. This is annoying because I am running arc lint --everything --never-apply-patches --output=xml > checkstyle.xml and the checkstyle.xml file is not valid XML.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC2924ebb9223c: Send arcanist error output to STDERR
Forced a linter to throw an exception and ran arc lint >/dev/null... saw error output.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think these should probably be fwrite() instead of fprintf() -- particularly, fprintf() will probably fail/error/something if the string has unescaped percent symbols?
That is, these are fine:
fwrite(STDERR, "Give 110%!"); fprintf(STDERR, "%s", "Give 100%!");
...but this is probably an error/warning?
fprintf(STDERR, "Give 110%!");