Page MenuHomePhabricator
Differential D13038

Provide more documentation for Arcanist upload stuff
ClosedPublic
Actions

Authored by epriestley on May 27 2015, 5:18 PM.
Tags
None
Referenced Files
F15478584: D13038.diff
Tue, Apr 8, 1:13 AM
F15456532: D13038.id31440.diff
Sun, Mar 30, 10:23 AM
F15453184: D13038.id31436.diff
Sat, Mar 29, 10:00 AM
F15450709: D13038.id.diff
Fri, Mar 28, 5:15 PM
F15444271: D13038.diff
Thu, Mar 27, 8:47 AM
F15430126: D13038.id31436.diff
Mon, Mar 24, 5:48 AM
F15417541: D13038.id31440.diff
Thu, Mar 20, 5:28 PM
F15380177: D13038.diff
Fri, Mar 14, 1:49 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8259: `arc diff` doesn't use chunked uploads
Commits
rARCa36dc81715f6: Provide more documentation for Arcanist upload stuff
Summary

Ref T8259. Make some highly-ambiguous methods like setData() more clear.

Test Plan

reading

Diff Detail

Repository
rARC Arcanist
Branch
upload3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6315
Build 6337: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31436.May 27 2015, 5:18 PM
epriestley retitled this revision from to Provide more documentation for Arcanist upload stuff.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8259: `arc diff` doesn't use chunked uploads.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 27 2015, 5:18 PM
epriestley added inline comments.May 27 2015, 5:19 PM
src/upload/ArcanistFileUploader.php
300

Oh, this mirrors ArcanistWorkflow->writeStatus() and gives us better behavior with the --json flags in some workflows.

I imagine some future iteration may add more explicit configuration around how progress is reported, but for now both callsites are fine with just writing to the console.

btrahan accepted this revision.May 27 2015, 5:22 PM
btrahan edited edge metadata.

Thanks man! I think this will be helpful at least to me someday in the future... :D

This revision is now accepted and ready to land.May 27 2015, 5:22 PM
Closed by commit rARCa36dc81715f6: Provide more documentation for Arcanist upload stuff (authored by epriestley, committed by epriestley). · Explain WhyMay 27 2015, 5:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
upload/
24 lines
26 lines

Diff 31436

View Options

src/upload/ArcanistFileDataRef.php

Loading...
View Options

src/upload/ArcanistFileUploader.php

Loading...
Phabricator · Built by Phacility