Differential D13022

Hide Land to GitHub
ClosedPublic
Actions

Authored by avivey on May 26 2015, 6:16 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T182: Commit into repository directly from differential
T8313: Can not land to Github

Commits

Restricted Diffusion Commit
rP08a9e0f22aff: Hide Land to GitHub

Summary

We don't want to support this right now, so disable it, similar to "Land To Hosted" feature.
Keep to the code as an example for advanced installs.

Ref T182, T8313

Test Plan

load a diff.

Diff Detail

Repository

rP Phabricator

Branch

hidegh

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6290
Build 6312: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 31404.May 26 2015, 6:16 PM

avivey retitled this revision from to Hide Land to GitHub.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added tasks: T8313: Can not land to Github, T182: Commit into repository directly from differential.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 26 2015, 6:16 PM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.May 26 2015, 6:21 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.May 26 2015, 6:21 PM

Closed by commit rP08a9e0f22aff: Hide Land to GitHub (authored by avivey, committed by epriestley). · Explain WhyMay 26 2015, 6:28 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D18150: Remove old "Landing Strategy" code.Jun 23 2017, 3:10 PM

epriestley mentioned this in rP219ae8b6c950: Remove old "Landing Strategy" code.Jun 23 2017, 3:14 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

landing/

DifferentialGitHubLandingStrategy.php

5 lines

Diff 31404

View Options

src/applications/differential/landing/DifferentialGitHubLandingStrategy.php

Hide Land to GitHubClosedPublicActions