HomePhabricator

Remove old "Landing Strategy" code

Authored by epriestley on Jun 23 2017, 2:51 PM.

Description

Remove old "Landing Strategy" code

Summary:
Fixes T12869. This is a very old, pre-Drydock chunk of code from D7486 and some followups.

It does three things:

  • "Land to Hosted Git": Obsoleted by Drydock, has been commented out in HEAD for a very long time with no complaints. Disabled by D8719 in 2014.
  • "Land to Hosted Mercurial": Could be obsoleted by Drydock with a fairly small amount of work, but currently has no replacement. Unclear if this sees any real use. Not actually disabled at HEAD.
  • "Land to GitHub": Use GitHub OAuth credentials to land to GitHub. This is sort of theoretically useful and has no analog today. Disabled by D13022 in 2015.

This stuff was largely disabled a long time ago and we haven't seen users hitting issues with it. This could all be moved to an extension today if anyone still relies on it.

Test Plan: Grepped for removed classes, browsed Differential.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12869

Differential Revision: https://secure.phabricator.com/D18150

Event Timeline

ztas raised a concern with this commit.EditedJun 26 2017, 10:31 AM
ztas added subscribers: epriestley, chad, ztas.

"Land Revision" button is now completely removed in DifferentialLandingActionMenu, even for local (non-hosted) Git repo's??

My team's release flow heavily relies on this UI feature instead of landing by merge/push manually.
We use "local" Git repo's and have setup DryDock like discribed here: https://secure.phabricator.com/book/phabricator/article/differential_land/

Any plans to bring the button back?

This commit now has outstanding concerns.Jun 26 2017, 10:31 AM
This commit no longer requires audit.Jun 26 2017, 11:14 AM

I removed this action mistakenly, and have restored it in D18154.

In the future, please see Support Resources for ways to get help from the upstream.

ztas added a comment.Jun 26 2017, 2:14 PM

Thanks for the quick fix on stable branch 😊