Page MenuHomePhabricator

elasticsearch host quick fix
ClosedPublic

Authored by fabe on May 21 2015, 3:44 PM.

Details

Summary

Quick fix for the elasticsearch search engine Ref T8274

Test Plan

Did a couple of searches

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6187
Build 6208: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

fabe retitled this revision from to elasticsearch host quick fix.
fabe updated this object.
fabe edited the test plan for this revision. (Show Details)
fabe added a reviewer: epriestley.

Can we just implement __construct().

That is:

public function __construct() {
  $this->uri = PhabricatorEnv::getEnvConfig('search.elastic.host');
  $this->index = PhabricatorEnv::getEnvConfig('search.elastic.namespace');
}
fabe edited edge metadata.

just use a constructor

just wasn't sure if there was a bette place to actually call setURI/Index.

epriestley edited edge metadata.

I don't think there is, currently.

This revision is now accepted and ready to land.May 21 2015, 4:01 PM
This revision was automatically updated to reflect the committed changes.