Return empty array as a default value for repository symbol languages
ClosedPublic
Actions

Authored by epriestley on May 21 2015, 2:30 PM.

Details

Reviewers

joshuaspence
btrahan
avivey

Maniphest Tasks

T8283: Error thrown when opening a file in Diffusion's file browser

Commits

Restricted Diffusion Commit
rPa50de8958efb: Return empty array as a default value for repository symbol languages

Summary

Fixes T8283. The code in FileController assumes this value is an array.

Test Plan

Loaded any file in Diffusion in unconfigured repository, no more warning.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31233.May 21 2015, 2:30 PM

epriestley retitled this revision from to Return empty array as a default value for repository symbol languages.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: avivey, joshuaspence, btrahan.

epriestley added a task: T8283: Error thrown when opening a file in Diffusion's file browser.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 21 2015, 2:30 PM

btrahan accepted this revision.May 21 2015, 4:27 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 21 2015, 4:27 PM

Closed by commit rPa50de8958efb: Return empty array as a default value for repository symbol languages (authored by epriestley, committed by epriestley). · Explain WhyMay 21 2015, 4:28 PM

This revision was automatically updated to reflect the committed changes.

avivey awarded a token.May 21 2015, 5:08 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

4 lines

Diff 31240

View Options

src/applications/repository/storage/PhabricatorRepository.php

Return empty array as a default value for repository symbol languagesClosedPublicActions