Don't call pht() from generate_nodes.php
ClosedPublic
Actions

Authored by epriestley on May 21 2015, 1:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 18, 12:20 PM

	Unknown Object (File)
	Thu, Nov 14, 11:40 AM

	Unknown Object (File)
	Sun, Nov 10, 1:01 PM

	Unknown Object (File)
	Wed, Nov 6, 12:52 PM

	Unknown Object (File)
	Sat, Nov 2, 6:26 AM

	Unknown Object (File)
	Fri, Nov 1, 5:11 AM

	Unknown Object (File)
	Tue, Oct 29, 2:37 PM

	Unknown Object (File)
	Oct 27 2024, 12:44 AM

View All Files

Subscribers

epriestley

Details

Reviewers

joshuaspence
btrahan

Commits

rPHU48bfe08e5fac: Don't call pht() from generate_nodes.php

Summary

This is part of the XHPAST build process and doesn't load libraries.

Test Plan

Ran the script.

Diff Detail

Repository

rPHU libphutil

Branch

nopht

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6183
Build 6204: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31231.May 21 2015, 1:57 PM

epriestley retitled this revision from to Don't call pht() from generate_nodes.php.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 21 2015, 1:57 PM

btrahan accepted this revision.May 21 2015, 4:27 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 21 2015, 4:27 PM

Closed by commit rPHU48bfe08e5fac: Don't call pht() from generate_nodes.php (authored by epriestley, committed by epriestley). · Explain WhyMay 21 2015, 4:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

xhpast/

generate_nodes.php

4 lines

Diff 31231

View Options

support/xhpast/generate_nodes.php

Don't call pht() from generate_nodes.phpClosedPublicActions