Don't call pht() from generate_nodes.php
ClosedPublic
Actions

Authored by epriestley on May 21 2015, 1:57 PM.

Tags

None

Referenced Files

	F15427220: D12963.id31231.diff
	Sun, Mar 23, 1:21 PM

	F15426751: D12963.id31241.diff
	Sun, Mar 23, 10:41 AM

	F15420944: D12963.id31231.diff
	Fri, Mar 21, 7:18 PM

	F15410035: D12963.id31231.diff
	Wed, Mar 19, 6:43 AM

	F15404890: D12963.id.diff
	Tue, Mar 18, 9:32 AM

	F15402752: D12963.diff
	Tue, Mar 18, 12:09 AM

	Unknown Object (File)
	Wed, Feb 26, 1:08 AM

	Unknown Object (File)
	Feb 12 2025, 3:15 AM

View All Files

Subscribers

epriestley

Details

Reviewers

joshuaspence
btrahan

Commits

rPHU48bfe08e5fac: Don't call pht() from generate_nodes.php

Summary

This is part of the XHPAST build process and doesn't load libraries.

Test Plan

Ran the script.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31231.May 21 2015, 1:57 PM

epriestley retitled this revision from to Don't call pht() from generate_nodes.php.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 21 2015, 1:57 PM

btrahan accepted this revision.May 21 2015, 4:27 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 21 2015, 4:27 PM

Closed by commit rPHU48bfe08e5fac: Don't call pht() from generate_nodes.php (authored by epriestley, committed by epriestley). · Explain WhyMay 21 2015, 4:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

xhpast/

generate_nodes.php

4 lines

Diff 31241

View Options

support/xhpast/generate_nodes.php

Don't call pht() from generate_nodes.phpClosedPublicActions