Page MenuHomePhabricator

[Redesign] Add Table, Collapse support to ObjectBox
ClosedPublic

Authored by chad on May 20 2015, 7:48 PM.

Details

Summary

Converts most all tables to be directly set via setTable to an ObjectBox. I think this path is more flexible design wise, as we can change the box based on children, and not just CSS. We also already do this with PropertyList, Forms, ObjectList, and Header. setCollapsed is added to ObjectBox to all children objects to bleed to the edges (like diffs). Ref T8099

Test Plan

I did a grep of appendChild($table) as well as searches for PHUIObjectBoxView, also with manual opening of hundreds of files. I'm sure I missed 5-8 places. If you just appendChild($table) nothing breaks, it just looks a little funny.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to [Redesign] Add Table, Collapse support to ObjectBox.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 20 2015, 9:14 PM

I think I derped this by not making a branch on redesign... how do I push it up without borking master?

You can just:

$ arc amend
$ git push

Or:

$ git checkout -b temporary # Create a new branch with your commit
$ git checkout redesign-2015 # Switch back to the main branch
$ git reset --hard origin/redesign-2015 # Reset the main branch to the remote version of it
$ arc land temporary # Land your change

I saw 'switching to branch master' and hit ctrl-c in like, 20ms.

This revision was automatically updated to reflect the committed changes.