HomePhabricator

[Redesign] Add Table, Collapse support to ObjectBox

Description

[Redesign] Add Table, Collapse support to ObjectBox

Summary: Converts most all tables to be directly set via setTable to an ObjectBox. I think this path is more flexible design wise, as we can change the box based on children, and not just CSS. We also already do this with PropertyList, Forms, ObjectList, and Header. setCollapsed is added to ObjectBox to all children objects to bleed to the edges (like diffs).

Test Plan: I did a grep of appendChild($table) as well as searches for PHUIObjectBoxView, also with manual opening of hundreds of files. I'm sure I missed 5-8 places. If you just appendChild($table) nothing breaks, it just looks a little funny.

Reviewers: epriestley, btrahan

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12955

Details

Provenance
Chad Little <chad@phacility.com>Authored on
chadPushed on May 20 2015, 9:44 PM
Differential Revision
D12955: [Redesign] Add Table, Collapse support to ObjectBox
Parents
rP667159eb077b: [Redesign] Add Table, Collapse support to ObjectBox
Branches
Unknown
Tags
Unknown