Converts most all tables to be directly set via setTable to an ObjectBox. I think this path is more flexible design wise, as we can change the box based on children, and not just CSS. We also already do this with PropertyList, Forms, ObjectList, and Header. setCollapsed is added to ObjectBox to all children objects to bleed to the edges (like diffs). Ref T8099
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T8099: Mid-2015 Phabricator Redesign
- Commits
- Restricted Diffusion Commit
Restricted Diffusion Commit
Restricted Diffusion Commit
rPba919b884628: map
rPa4784e03fff4: [Redesign] Add Table, Collapse support to ObjectBox
rP667159eb077b: [Redesign] Add Table, Collapse support to ObjectBox
I did a grep of appendChild($table) as well as searches for PHUIObjectBoxView, also with manual opening of hundreds of files. I'm sure I missed 5-8 places. If you just appendChild($table) nothing breaks, it just looks a little funny.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think I derped this by not making a branch on redesign... how do I push it up without borking master?
Comment Actions
You can just:
$ arc amend $ git push
Or:
$ git checkout -b temporary # Create a new branch with your commit $ git checkout redesign-2015 # Switch back to the main branch $ git reset --hard origin/redesign-2015 # Reset the main branch to the remote version of it $ arc land temporary # Land your change