Page MenuHomePhabricator
Differential D12948

Raise a setup issue for misconfigured Elasticsearch
ClosedPublic
Actions

Authored by epriestley on May 20 2015, 1:23 PM.
Tags
None
Referenced Files
F14064443: D12948.diff
Mon, Nov 18, 11:32 PM
F14052406: D12948.diff
Fri, Nov 15, 8:50 AM
F14038065: D12948.diff
Sun, Nov 10, 9:20 PM
F14029739: D12948.id31185.diff
Fri, Nov 8, 9:07 PM
F14029096: D12948.id31207.diff
Fri, Nov 8, 7:24 PM
F14028978: D12948.id31207.diff
Fri, Nov 8, 6:35 PM
F14028949: D12948.id31185.diff
Fri, Nov 8, 6:17 PM
F14023344: D12948.diff
Thu, Nov 7, 1:11 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T8274: Misconfigured Elasticsearch can fatal the setup issue process
Commits
Restricted Diffusion Commit
rPf5a9d1f8d47b: Raise a setup issue for misconfigured Elasticsearch
Summary

Fixes T8274. That report is very light on details, but I think the issue is that their Elasticsearch is misconfigured and the new setup warning dies a little too hard if the server is just completely dead.

Test Plan

Set search.elastic.host to an invalid server, got a similar-looking exception (?), applied patch, got a setup warning instead.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31185.May 20 2015, 1:23 PM
epriestley retitled this revision from to Raise a setup issue for misconfigured Elasticsearch.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
epriestley added a task: T8274: Misconfigured Elasticsearch can fatal the setup issue process.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 20 2015, 1:23 PM
epriestley mentioned this in T8274: Misconfigured Elasticsearch can fatal the setup issue process.May 20 2015, 2:38 PM
btrahan accepted this revision.May 20 2015, 8:47 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/config/check/PhabricatorElasticSearchSetupCheck.php
19–21

these methods existed already? cool!

This revision is now accepted and ready to land.May 20 2015, 8:47 PM
joshuaspence accepted this revision.May 20 2015, 8:52 PM
joshuaspence edited edge metadata.
Closed by commit rPf5a9d1f8d47b: Raise a setup issue for misconfigured Elasticsearch (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2015, 9:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
91 lines

Diff 31207

View Options

src/applications/config/check/PhabricatorElasticSearchSetupCheck.php

Loading...
Phabricator · Built by Phacility