Differential D12712

Remove "commit hook mode" check from Javelin linter
ClosedPublic
Actions

Authored by joshuaspence on May 5 2015, 11:03 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7674: Remove support for arc commit hooks

Commits

Restricted Diffusion Commit
rPe225998fce54: Remove "commit hook mode" check from Javelin linter

Summary

Ref T7674. Commit hook mode is going away.

Test Plan

Eyeball it.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5757
Build 5776: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30536.May 5 2015, 11:03 AM

joshuaspence retitled this revision from to Remove "commit hook mode" check from Javelin linter.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7674: Remove support for arc commit hooks.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 5 2015, 11:03 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence added a child revision: D12698: Remove hook functionality.May 5 2015, 11:03 AM

epriestley accepted this revision.May 5 2015, 11:10 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 5 2015, 11:10 AM

Closed by commit rPe225998fce54: Remove "commit hook mode" check from Javelin linter (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 5 2015, 11:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

lint/

linter/

PhabricatorJavelinLinter.php

6 lines

Diff 30536

View Options

src/infrastructure/lint/linter/PhabricatorJavelinLinter.php

Remove "commit hook mode" check from Javelin linterClosedPublicActions