Differential D12698

Remove hook functionality
ClosedPublic
Actions

Authored by joshuaspence on May 4 2015, 3:01 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7674: Remove support for arc commit hooks

Commits

rARC8919a9c5b55e: Remove hook functionality

Summary

Fixes T7674. Remove remaining commit hook functionality.

Test Plan

Unit tests still pass?

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30482.May 4 2015, 3:01 PM

joshuaspence retitled this revision from to Remove hook functionality.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7674: Remove support for arc commit hooks.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2015, 3:01 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 4 2015, 3:03 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 4 2015, 3:03 PM

epriestley awarded a token.May 4 2015, 3:03 PM

btrahan awarded a token.May 4 2015, 4:48 PM

joshuaspence added a parent revision: D12712: Remove "commit hook mode" check from Javelin linter.May 5 2015, 11:03 AM

Closed by commit rARC8919a9c5b55e: Remove hook functionality (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 5 2015, 12:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

3 lines

lint/

engine/

ArcanistLintEngine.php

52 lines

linter/

ArcanistLinter.php

9 lines

__tests__/

ArcanistLinterTestCase.php

3 lines

spelling/

spell.lint-test

5 lines

repository/

api/

ArcanistGitAPI.php

13 lines

hookapi/

ArcanistHookAPI.php

ArcanistSubversionHookAPI.php

Diff 30548

View Options

src/__phutil_library_map__.php

View Options

src/lint/engine/ArcanistLintEngine.php

View Options

src/lint/linter/ArcanistLinter.php

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

View Options

src/lint/linter/tests/spelling/spell.lint-test

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/repository/hookapi/ArcanistHookAPI.php

View Options

src/repository/hookapi/ArcanistSubversionHookAPI.php

Remove hook functionalityClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30548

src/__phutil_library_map__.php

src/lint/engine/ArcanistLintEngine.php

src/lint/linter/ArcanistLinter.php

src/lint/linter/__tests__/ArcanistLinterTestCase.php

src/lint/linter/__tests__/spelling/spell.lint-test

src/repository/api/ArcanistGitAPI.php

src/repository/hookapi/ArcanistHookAPI.php

src/repository/hookapi/ArcanistSubversionHookAPI.php

Remove hook functionality
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/tests/ArcanistLinterTestCase.php

src/lint/linter/tests/spelling/spell.lint-test