Paths

Table of Contentst

Differential D12679

Use phutil_json_decode instead of json_decode
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 9:15 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU040d1599fe01: Use phutil_json_decode instead of json_decode

Summary

Generally, phutil_json_decode should be preferred over json_decode.

Test Plan

Eyeballed.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30444.May 3 2015, 9:15 PM

joshuaspence retitled this revision from to Use phutil_json_decode instead of json_decode.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 9:15 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 3 2015, 9:20 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 3 2015, 9:20 PM

Closed by commit rPHU040d1599fe01: Use phutil_json_decode instead of json_decode (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 4 2015, 9:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

auth/

PhutilAmazonAuthAdapter.php

13 lines

PhutilDisqusAuthAdapter.php

14 lines

PhutilFacebookAuthAdapter.php

12 lines

PhutilGitHubAuthAdapter.php

13 lines

PhutilGoogleAuthAdapter.php

13 lines

PhutilPersonaAuthAdapter.php

10 lines

PhutilPhabricatorAuthAdapter.php

14 lines

channel/

PhutilJSONProtocolChannel.php

11 lines

conduit/

ConduitFuture.php

14 lines

daemon/

PhutilDaemonHandle.php

5 lines

future/

asana/

PhutilAsanaFuture.php

10 lines

exec/

ExecFuture.php

12 lines

oauth/

PhutilOAuth1Future.php

9 lines

twitch/

PhutilTwitchFuture.php

10 lines

moduleutils/

PhutilLibraryMapBuilder.php

5 lines

parser/

xhpast/

__tests__/

PHPASTParserTestCase.php

20 lines

Diff 30509

View Options

src/auth/PhutilAmazonAuthAdapter.php

View Options

src/auth/PhutilDisqusAuthAdapter.php

View Options

src/auth/PhutilFacebookAuthAdapter.php

View Options

src/auth/PhutilGitHubAuthAdapter.php

View Options

src/auth/PhutilGoogleAuthAdapter.php

View Options

src/auth/PhutilPersonaAuthAdapter.php

View Options

src/auth/PhutilPhabricatorAuthAdapter.php

View Options

src/channel/PhutilJSONProtocolChannel.php

View Options

src/conduit/ConduitFuture.php

View Options

src/daemon/PhutilDaemonHandle.php

View Options

src/future/asana/PhutilAsanaFuture.php

View Options

src/future/exec/ExecFuture.php

View Options

src/future/oauth/PhutilOAuth1Future.php

View Options

src/future/twitch/PhutilTwitchFuture.php

View Options

src/moduleutils/PhutilLibraryMapBuilder.php

View Options

src/parser/xhpast/tests/PHPASTParserTestCase.php

Use phutil_json_decode instead of json_decodeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30509

src/auth/PhutilAmazonAuthAdapter.php

src/auth/PhutilDisqusAuthAdapter.php

src/auth/PhutilFacebookAuthAdapter.php

src/auth/PhutilGitHubAuthAdapter.php

src/auth/PhutilGoogleAuthAdapter.php

src/auth/PhutilPersonaAuthAdapter.php

src/auth/PhutilPhabricatorAuthAdapter.php

src/channel/PhutilJSONProtocolChannel.php

src/conduit/ConduitFuture.php

src/daemon/PhutilDaemonHandle.php

src/future/asana/PhutilAsanaFuture.php

src/future/exec/ExecFuture.php

src/future/oauth/PhutilOAuth1Future.php

src/future/twitch/PhutilTwitchFuture.php

src/moduleutils/PhutilLibraryMapBuilder.php

src/parser/xhpast/__tests__/PHPASTParserTestCase.php

Use phutil_json_decode instead of json_decode
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/PHPASTParserTestCase.php