Paths

Table of Contentst

Differential D12679

Use phutil_json_decode instead of json_decode
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 9:15 PM.

Tags

None

Referenced Files

	F15703140: D12679.diff
	Wed, May 28, 10:32 PM

	F15703053: D12679.id30509.diff
	Wed, May 28, 10:26 PM

	Unknown Object (File)
	Tue, May 27, 10:39 PM

	Unknown Object (File)
	Sun, May 11, 9:42 AM

	Unknown Object (File)
	Apr 29 2025, 2:54 AM

	Unknown Object (File)
	Apr 8 2025, 1:11 AM

	Unknown Object (File)
	Apr 6 2025, 12:34 AM

	Unknown Object (File)
	Apr 4 2025, 9:49 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU040d1599fe01: Use phutil_json_decode instead of json_decode

Summary

Generally, phutil_json_decode should be preferred over json_decode.

Test Plan

Eyeballed.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5705
Build 5724: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	64 ms	PHPASTParserTestCase::testParser
	40 ms	ConduitClientTestCase::testConduitRequestEncoding
	163 ms	ExecFutureTestCase::testBufferLimit
	72 ms	ExecFutureTestCase::testEmptyWrite
	62 ms	ExecFutureTestCase::testKeepPipe
		View Full Test Results (1 Failed · 62 Passed)

Event Timeline

joshuaspence updated this revision to Diff 30444.May 3 2015, 9:15 PM

joshuaspence retitled this revision from to Use phutil_json_decode instead of json_decode.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 9:15 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 3 2015, 9:20 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 3 2015, 9:20 PM

Closed by commit rPHU040d1599fe01: Use phutil_json_decode instead of json_decode (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 4 2015, 9:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

auth/

PhutilAmazonAuthAdapter.php

13 lines

PhutilDisqusAuthAdapter.php

14 lines

PhutilFacebookAuthAdapter.php

12 lines

PhutilGitHubAuthAdapter.php

13 lines

PhutilGoogleAuthAdapter.php

13 lines

PhutilPersonaAuthAdapter.php

10 lines

PhutilPhabricatorAuthAdapter.php

14 lines

channel/

PhutilJSONProtocolChannel.php

11 lines

conduit/

ConduitFuture.php

14 lines

future/

asana/

PhutilAsanaFuture.php

10 lines

exec/

6 lines

oauth/

PhutilOAuth1Future.php

9 lines

twitch/

PhutilTwitchFuture.php

10 lines

parser/

xhpast/

__tests__/

PHPASTParserTestCase.php

22 lines

Diff 30444

src/auth/PhutilAmazonAuthAdapter.php

Loading...

src/auth/PhutilDisqusAuthAdapter.php

Loading...

src/auth/PhutilFacebookAuthAdapter.php

Loading...

src/auth/PhutilGitHubAuthAdapter.php

Loading...

src/auth/PhutilGoogleAuthAdapter.php

Loading...

src/auth/PhutilPersonaAuthAdapter.php

Loading...

src/auth/PhutilPhabricatorAuthAdapter.php

Loading...

src/channel/PhutilJSONProtocolChannel.php

Loading...

src/conduit/ConduitFuture.php

Loading...

src/future/asana/PhutilAsanaFuture.php

Loading...

src/future/exec/ExecFuture.php

Loading...

src/future/oauth/PhutilOAuth1Future.php

Loading...

src/future/twitch/PhutilTwitchFuture.php

Loading...

src/parser/xhpast/tests/PHPASTParserTestCase.php

Loading...