Page MenuHomePhabricator

Refine global search UI for tokenizer functions
ClosedPublic

Authored by epriestley on Apr 23 2015, 10:19 AM.
Tags
None
Referenced Files
F13049061: D12523.diff
Fri, Apr 19, 12:54 AM
F13046078: D12523.id30069.diff
Thu, Apr 18, 6:13 AM
Unknown Object (File)
Thu, Apr 11, 7:35 AM
Unknown Object (File)
Tue, Apr 9, 4:00 PM
Unknown Object (File)
Fri, Apr 5, 4:58 PM
Unknown Object (File)
Wed, Apr 3, 5:25 AM
Unknown Object (File)
Thu, Mar 28, 6:53 PM
Unknown Object (File)
Mar 13 2024, 9:24 AM
Subscribers

Details

Summary

Ref T4100.

  • Removes the "with unowned" checkbox in favor of the "no owners" function.
  • Support functions in "Authors" and "Owners".
Test Plan
  • Ran various global search and Maniphest queries.

Screen_Shot_2015-04-23_at_3.17.17_AM.png (385×1 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Refine global search UI for tokenizer functions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php
82–83

surprised this is necessary

This revision is now accepted and ready to land.Apr 23 2015, 5:00 PM
src/applications/project/typeahead/PhabricatorProjectMembersDatasource.php
82–83

The token is originally coming from the underlying Project tokenizer, which sets the color on it if the project has a color. If it was just freshly created we wouldn't have to do it.

We could do something else like automatically ignore colors on function tokens, but it's possible that we'll want colored functions or something. This may end up getting cleaned up if we don't adjust the design much, though.

This revision was automatically updated to reflect the committed changes.