Let ghostly inlines automatically expand changesets in enormous diffs
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 7:57 PM.

Details

Reviewers

Maniphest Tasks

T7447: Bring inline comments forward across revision updates
T7870: List of cases where ghost comments end up somewhere confusing or unexpected

Commits

Restricted Diffusion Commit
rPa4a65bd5f1d6: Let ghostly inlines automatically expand changesets in enormous diffs

Summary

Ref T7447. Ref T7870. When a diff affects more than 100 files, we collapse files by default, then expand files with inlines.

Ghostly inlines currently don't cause files to expand, but reasonably should.

Test Plan

Before:

After:

Screen_Shot_2015-04-21_at_12.51.44_PM.png (1×1 px, 160 KB)

Diff Detail

Repository

rP Phabricator

Branch

ghost1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5423
Build 5441: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30002.Apr 21 2015, 7:57 PM

epriestley retitled this revision from to Let ghostly inlines automatically expand changesets in enormous diffs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7870: List of cases where ghost comments end up somewhere confusing or unexpected, T7447: Bring inline comments forward across revision updates.

Herald added subscribers: epriestley, yelirekim. · View Herald TranscriptApr 21 2015, 7:57 PM

epriestley mentioned this in T7870: List of cases where ghost comments end up somewhere confusing or unexpected.Apr 21 2015, 8:01 PM

btrahan accepted this revision.Apr 21 2015, 10:13 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 21 2015, 10:13 PM

Closed by commit rPa4a65bd5f1d6: Let ghostly inlines automatically expand changesets in enormous diffs (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 10:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

215 lines

DifferentialRevisionViewController.php

39 lines

query/

DifferentialInlineCommentQuery.php

188 lines

Diff 30002

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

View Options

src/applications/differential/query/DifferentialInlineCommentQuery.php

Let ghostly inlines automatically expand changesets in enormous diffsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30002

src/applications/differential/controller/DifferentialChangesetViewController.php

src/applications/differential/controller/DifferentialRevisionViewController.php

src/applications/differential/query/DifferentialInlineCommentQuery.php

Let ghostly inlines automatically expand changesets in enormous diffs
ClosedPublic
Actions

Revision Contents
Changeset List