Page MenuHomePhabricator
Differential D12465

Tweak colors of new magic tokens
ClosedPublic
Actions

Authored by chad on Apr 18 2015, 8:34 PM.
Tags
None
Referenced Files
F14815221: D12465.diff
Mon, Jan 27, 7:27 PM
F14813591: D12465.id29914.diff
Mon, Jan 27, 12:32 PM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
Unknown Object (File)
Fri, Jan 24, 2:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5746: Phabricator does not show project color in Projects Typeahead field
T7452: Tokenizer seems 1px off
Commits
Restricted Diffusion Commit
rP6c0b8b7d0499: Tweak colors of new magic tokens
Summary

Uses shades for token colors, makes function tokens white/blue.

Test Plan

Used the new tokens in UIExamples, Differential.

pasted_file (279×1 px, 69 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29914.Apr 18 2015, 8:34 PM
chad retitled this revision from to Tweak colors of new magic tokens.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 18 2015, 8:34 PM
chad added a comment.Apr 18 2015, 8:35 PM

Is it easy to color the project tags now? I looked briefly into it, but wasn't sure what you had in mind.

epriestley edited edge metadata.Apr 18 2015, 9:47 PM

Should be easy, yeah. Let me shoot you a diff when I get a chance -- I think we're running some errands first.

chad updated this revision to Diff 29915.Apr 19 2015, 3:42 AM
chad edited edge metadata.

update

epriestley added a comment.Apr 19 2015, 12:50 PM

Sorry, lots of errands yesterday and then I was sleepy.

epriestley mentioned this in D12467: Give tokenizer tokens CSS color classes on the container instead of the icon.Apr 19 2015, 1:12 PM
epriestley mentioned this in rP8f61eb45ab3b: Give tokenizer tokens CSS color classes on the container instead of the icon.Apr 19 2015, 2:18 PM
chad updated this revision to Diff 29926.Apr 19 2015, 3:51 PM
  • Update Tokenizer tag colors
  • add new colors
chad edited the test plan for this revision. (Show Details)Apr 19 2015, 3:51 PM
epriestley accepted this revision.Apr 19 2015, 4:05 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2015, 4:05 PM
chad added a comment.Apr 19 2015, 4:08 PM

Not sold on anything in particular on the magic tokens, but I want to play with them live for a few before making changes. Maybe these suck or something.

Closed by commit rP6c0b8b7d0499: Tweak colors of new magic tokens (authored by chad, committed by chad). · Explain WhyApr 19 2015, 4:08 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Apr 19 2015, 4:37 PM

They feel a little subtle to me at first glance, but we can see how they go.

chad added a task: T7452: Tokenizer seems 1px off.Apr 19 2015, 5:17 PM
epriestley added a task: T5746: Phabricator does not show project color in Projects Typeahead field.Apr 19 2015, 6:20 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
47 lines
webroot/
rsrc/
css/
aphront/
39 lines
phui/
167 lines

Diff 29927

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/aphront/tokenizer.css

Loading...
View Options

webroot/rsrc/css/phui/phui-tag-view.css

Loading...
Phabricator · Built by Phacility