Page MenuHomePhabricator

Tweak colors of new magic tokens
ClosedPublic

Authored by chad on Apr 18 2015, 8:34 PM.

Details

Summary

Uses shades for token colors, makes function tokens white/blue.

Test Plan

Used the new tokens in UIExamples, Differential.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad retitled this revision from to Tweak colors of new magic tokens.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

Is it easy to color the project tags now? I looked briefly into it, but wasn't sure what you had in mind.

Should be easy, yeah. Let me shoot you a diff when I get a chance -- I think we're running some errands first.

chad edited edge metadata.

update

Sorry, lots of errands yesterday and then I was sleepy.

  • Update Tokenizer tag colors
  • add new colors
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2015, 4:05 PM

Not sold on anything in particular on the magic tokens, but I want to play with them live for a few before making changes. Maybe these suck or something.

This revision was automatically updated to reflect the committed changes.

They feel a little subtle to me at first glance, but we can see how they go.