For the price of loading transactions more consistently, we get a better subtitle. We do this in all cases EXCEPT for when we're grabbing handles, because that makes the handles pretty heavy weight and I could even feel the perf hit on my development machine and we don't use subtitle there anyway. We may want to cache the latest message on the conpherence thread object to improve performance here as well as consider falling back to "A, B, C..." more often. Code is written such that no transactions means an automagical fallback.
- Maniphest Tasks
- T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence
- Restricted Diffusion Commit
rP78bfcc32217a: Conpherence - change "A, B, C..." subtitle to "A: what most recent person…
played around with conpherence in both views and things seemed to work nicely.
made sure to try the original repro in T7795 and couldn't get that to go either
posted a long comment and verified that the CSS / string truncation both make it display nicely. Note that without the CSS the chosen glyph value can be too high to fit nicely at times.
We could also specialize the transaction subquery to get the most recent comment at some point, but that'd be more code so it feels reasonable to wait for this to show up on a profile.
Maybe consider getTransactions() and getTransactionsIfAttached() or similar (or a hasAttachedTransactions() method) to make intent more clear.