Audit - fix a bug with unloaded repositories
ClosedPublic
Actions

Authored by btrahan on Apr 10 2015, 6:25 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rP9a49c8139374: Audit - fix a bug with unloaded repositories

Summary

...because its always at least the string <ATTACHABLE>... Not sure when we'd hit this / see the TODO about making it better, but its definitely a logic bug right now.

(an update to D12347 helped me notice that this conditional is always hit and may fatal later)

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29665.Apr 10 2015, 6:25 PM

btrahan retitled this revision from to Audit - fix a bug with unloaded repositories.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 10 2015, 6:25 PM

epriestley accepted this revision.Apr 11 2015, 7:01 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 11 2015, 7:01 AM

Closed by commit rP9a49c8139374: Audit - fix a bug with unloaded repositories (authored by btrahan, committed by btrahan). · Explain WhyApr 12 2015, 4:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

4 lines

Diff 29691

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Audit - fix a bug with unloaded repositoriesClosedPublicActions