Page MenuHomePhabricator

Audit - fix a bug with unloaded repositories
ClosedPublic

Authored by btrahan on Apr 10 2015, 6:25 PM.
Tags
None
Referenced Files
F18779309: D12348.id29691.diff
Sat, Oct 11, 1:22 PM
F18767396: D12348.id.diff
Tue, Oct 7, 10:25 PM
F18759899: D12348.diff
Mon, Oct 6, 6:35 AM
F18672229: D12348.id29665.diff
Thu, Sep 25, 7:02 AM
F18647148: D12348.diff
Sep 19 2025, 12:21 PM
F18565856: D12348.id.diff
Sep 9 2025, 1:47 PM
F18504126: D12348.id.diff
Sep 4 2025, 11:37 PM
F18497098: D12348.diff
Sep 4 2025, 5:52 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP9a49c8139374: Audit - fix a bug with unloaded repositories
Summary

...because its always at least the string <ATTACHABLE>... Not sure when we'd hit this / see the TODO about making it better, but its definitely a logic bug right now.

(an update to D12347 helped me notice that this conditional is always hit and may fatal later)

Test Plan

NA

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Audit - fix a bug with unloaded repositories.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 11 2015, 7:01 AM
This revision was automatically updated to reflect the committed changes.