Page MenuHomePhabricator
Differential D12399

Conpherenece - improve performance by not fetching data as often from D12347
ClosedPublic
Actions

Authored by btrahan on Apr 13 2015, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 5:35 PM
Unknown Object (File)
Mon, Dec 9, 2:03 PM
Unknown Object (File)
Sun, Dec 8, 2:37 PM
Unknown Object (File)
Wed, Dec 4, 11:42 AM
Unknown Object (File)
Tue, Dec 3, 2:29 AM
Unknown Object (File)
Sat, Nov 30, 12:27 AM
Unknown Object (File)
Mon, Nov 25, 11:51 PM
Unknown Object (File)
Sun, Nov 24, 9:54 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7815: Conpherence threads ordering messed up; perf maybe too bad now too?
Commits
Restricted Diffusion Commit
rPf12839ffd414: Conpherenece - improve performance by not fetching data as often from D12347
Summary

Turns out the pertinent views don't use this data anyway. Additonally, change the remaining pathway to fetch 15% of the rows it fetched in D12347. Fixes T7815.

Test Plan

clicked around and things worked. my instance always feels snappy though

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29775.Apr 13 2015, 7:42 PM
btrahan retitled this revision from to Conpherenece - improve performance by not fetching data as often from D12347.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a task: T7815: Conpherence threads ordering messed up; perf maybe too bad now too?.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 13 2015, 7:42 PM
epriestley accepted this revision.Apr 13 2015, 7:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 7:43 PM
Closed by commit rPf12839ffd414: Conpherenece - improve performance by not fetching data as often from D12347 (authored by btrahan, committed by btrahan). · Explain WhyApr 13 2015, 7:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29776

View Options

src/applications/conpherence/controller/ConpherenceColumnViewController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceListController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Loading...
Phabricator · Built by Phacility