Page MenuHomePhabricator

Conpherence - improve stack re: non-update updates
ClosedPublic

Authored by btrahan on Apr 9 2015, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 2:34 AM
Unknown Object (File)
Tue, Dec 17, 9:51 AM
Unknown Object (File)
Fri, Dec 6, 8:32 PM
Unknown Object (File)
Thu, Dec 5, 3:41 PM
Unknown Object (File)
Wed, Dec 4, 8:11 PM
Unknown Object (File)
Wed, Dec 4, 8:10 PM
Unknown Object (File)
Mon, Dec 2, 7:38 AM
Unknown Object (File)
Mon, Dec 2, 7:38 AM
Subscribers

Details

Summary

Fixes T7761. Fixes T7318.

When we send an empty message to the server, pretend its just a request to load the page. Make load a bit smarter such that if we don't get back any transactions, rather than error like the fool, just send down to the client the notion of a 'non_update'. Instrument the client to just turn off the appropriate loading state, etc for a non update.

T7318 is a tricky beast since we don't know exactly how to reproduce it but if / when it occurs again it would be some other bizarre application behavior maybe? We won't be getting the execption anymore, that's for sure.

Test Plan

removed code in ConpherenceThreadManager.sendMessage that protects against sending empty messages. sent empty messages (non updates) like whoa and everything worked on both durable column and main column view. re-added the code in ConpherenceThreadManager.sendMessage and noted empty messages did not send while any text including a space sent up nicely

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence - improve stack re: non-update updates.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/conpherence/controller/ConpherenceUpdateController.php
79–89

Should probably be strlen($message) or you won't be able to say "0".

This revision is now accepted and ready to land.Apr 9 2015, 10:05 PM
btrahan edited edge metadata.

use strlen so "0" works

This revision was automatically updated to reflect the committed changes.