Page MenuHomePhabricator

Don't pass data to `jshint` via STDIN

Authored by joshuaspence on Apr 6 2015, 12:36 PM.



Fixes T7464. JSHint is unable to exclude files from linting (via the jshintignore file) if the data is piped through STDIN. An alternative would be to pass $options[] = '--filename='.$this->getActivePath(), but $this->getActivePath() is not set when the command arguments are constructed.

Test Plan

Created a file and linted it with ArcanistJSHintLinter. Was able to exclude the file from linting with a jshintignore file.

Diff Detail

rARC Arcanist
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence retitled this revision from to Don't pass data to `jshint` via STDIN.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley accepted this revision.Apr 6 2015, 12:45 PM
epriestley edited edge metadata.

This approach is consistent with my intent via T7674.

This revision is now accepted and ready to land.Apr 6 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.