Page MenuHomePhabricator

Don't pass data to `jshint` via STDIN
ClosedPublic

Authored by joshuaspence on Apr 6 2015, 12:36 PM.
Tags
None
Referenced Files
F11025658: D12298.id29558.diff
Fri, Aug 12, 1:32 PM
Unknown Object (File)
Sat, Jul 30, 7:43 PM
Unknown Object (File)
Jul 2 2022, 12:43 PM
Unknown Object (File)
Jun 12 2022, 10:40 AM
Unknown Object (File)
Jun 10 2022, 9:26 AM
Unknown Object (File)
Jun 5 2022, 3:56 PM
Unknown Object (File)
May 28 2022, 9:21 PM
Unknown Object (File)
May 25 2022, 10:20 AM
Subscribers

Details

Summary

Fixes T7464. JSHint is unable to exclude files from linting (via the jshintignore file) if the data is piped through STDIN. An alternative would be to pass $options[] = '--filename='.$this->getActivePath(), but $this->getActivePath() is not set when the command arguments are constructed.

Test Plan

Created a file and linted it with ArcanistJSHintLinter. Was able to exclude the file from linting with a jshintignore file.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Don't pass data to `jshint` via STDIN.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

This approach is consistent with my intent via T7674.

This revision is now accepted and ready to land.Apr 6 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.