Page MenuHomePhabricator

Don't pass data to `jshint` via STDIN
ClosedPublic

Authored by joshuaspence on Apr 6 2015, 12:36 PM.
Tags
None
Referenced Files
F19090335: D12298.id.diff
Dec 3 2025, 11:13 AM
F19085665: D12298.diff
Dec 2 2025, 7:11 PM
F19016252: D12298.id29528.diff
Nov 23 2025, 3:20 AM
F18920811: D12298.id.diff
Nov 9 2025, 1:23 PM
F18915274: D12298.id29558.diff
Nov 9 2025, 7:36 AM
F18877321: D12298.id29558.diff
Nov 6 2025, 7:28 AM
F18856718: D12298.id.diff
Nov 1 2025, 11:15 AM
F18853849: D12298.diff
Oct 31 2025, 8:02 PM
Subscribers

Details

Summary

Fixes T7464. JSHint is unable to exclude files from linting (via the jshintignore file) if the data is piped through STDIN. An alternative would be to pass $options[] = '--filename='.$this->getActivePath(), but $this->getActivePath() is not set when the command arguments are constructed.

Test Plan

Created a file and linted it with ArcanistJSHintLinter. Was able to exclude the file from linting with a jshintignore file.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Don't pass data to `jshint` via STDIN.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

This approach is consistent with my intent via T7674.

This revision is now accepted and ready to land.Apr 6 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.