Page MenuHomePhabricator

Don't pass data to `jshint` via STDIN
ClosedPublic

Authored by joshuaspence on Apr 6 2015, 12:36 PM.
Tags
None
Referenced Files
F17948307: D12298.id.diff
Thu, Jul 31, 8:44 PM
F17948282: D12298.id29528.diff
Thu, Jul 31, 8:42 PM
F17947453: D12298.id29528.diff
Thu, Jul 31, 4:45 PM
F17946152: D12298.id.diff
Thu, Jul 31, 1:37 PM
F17938041: D12298.diff
Thu, Jul 31, 1:46 AM
F17931674: D12298.diff
Wed, Jul 30, 7:21 PM
F17849313: D12298.diff
Jul 27 2025, 8:32 AM
Unknown Object (File)
Jul 1 2025, 10:41 AM
Subscribers

Details

Summary

Fixes T7464. JSHint is unable to exclude files from linting (via the jshintignore file) if the data is piped through STDIN. An alternative would be to pass $options[] = '--filename='.$this->getActivePath(), but $this->getActivePath() is not set when the command arguments are constructed.

Test Plan

Created a file and linted it with ArcanistJSHintLinter. Was able to exclude the file from linting with a jshintignore file.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Don't pass data to `jshint` via STDIN.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

This approach is consistent with my intent via T7674.

This revision is now accepted and ready to land.Apr 6 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.