Page MenuHomePhabricator

Don't pass data to `jshint` via STDIN
ClosedPublic

Authored by joshuaspence on Apr 6 2015, 12:36 PM.
Tags
None
Referenced Files
F19016252: D12298.id29528.diff
Sun, Nov 23, 3:20 AM
F18920811: D12298.id.diff
Sun, Nov 9, 1:23 PM
F18915274: D12298.id29558.diff
Sun, Nov 9, 7:36 AM
F18877321: D12298.id29558.diff
Thu, Nov 6, 7:28 AM
F18856718: D12298.id.diff
Sat, Nov 1, 11:15 AM
F18853849: D12298.diff
Fri, Oct 31, 8:02 PM
F18737530: D12298.id.diff
Oct 1 2025, 11:17 AM
F18732434: D12298.diff
Sep 30 2025, 6:13 PM
Subscribers

Details

Summary

Fixes T7464. JSHint is unable to exclude files from linting (via the jshintignore file) if the data is piped through STDIN. An alternative would be to pass $options[] = '--filename='.$this->getActivePath(), but $this->getActivePath() is not set when the command arguments are constructed.

Test Plan

Created a file and linted it with ArcanistJSHintLinter. Was able to exclude the file from linting with a jshintignore file.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Don't pass data to `jshint` via STDIN.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

This approach is consistent with my intent via T7674.

This revision is now accepted and ready to land.Apr 6 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.