These arrays looks a little odd, most likely due to the autofix applied by ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR. See D12296 in which I attempt to improve the autocorrection from this linter rule.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPea376685ae9e: Fix some odd looking arrays
N/A
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5125 Build 5143: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/view/phui/PHUITimelineEventView.php | ||
|---|---|---|
| 438 | I'm actually not sure that this is meant to be an array element, it seems rather odd. | |
| src/view/phui/PHUITimelineEventView.php | ||
|---|---|---|
| 438 | Oh, this is trying to be "tag with no body". The '' can just be omitted completely. | |
Comment Actions
That is, instead of f(x, array(y), '') it's incorrectly written as f(x, array(y, '')). But f(x, array(y)) is equivalent.