Paths

Table of Contentst

Differential D12280

Fix an odd looking array
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 6:39 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC3eacb08273de: Fix an odd looking array

Summary

This array looks a little odd, most likely due to the autofix applied by ArcanistXHPASTLinter::LINT_ARRAY_SEPARATOR. See D12296 in which I attempt to improve the autocorrection from this linter rule.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5124
Build 5142: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29483.Apr 5 2015, 6:39 AM

joshuaspence retitled this revision from to Fix an odd looking array.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 6:39 AM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Apr 5 2015, 12:19 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Apr 5 2015, 12:19 PM

joshuaspence updated this object.Apr 5 2015, 12:27 PM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

Closed by commit rARC3eacb08273de: Fix an odd looking array (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:29 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D12296: Improve array comma rule.Apr 5 2015, 1:05 PM

joshuaspence mentioned this in rARC3a5ffdc2fdf2: Improve array comma rule.Apr 6 2015, 9:52 PM

Revision Contents
Changeset List

Path

Size

scripts/

arcanist.php

3 lines

Diff 29483

View Options

Fix an odd looking arrayClosedPublicActions