Fixes T7658. Currently, we remove the "undo" before placing the comment, but that causes us to lose track of which row we should be examining.
Instead, place the comment first, then remove the "undo".
Details
Details
- Reviewers
btrahan chad - Maniphest Tasks
- T7658: Deleting a draft inline comment and adding new inline comment moves the new comment to end of file.
- Commits
- Restricted Diffusion Commit
rPc03297ab5a0a: Fix interaction between undo and inline comment placement
This stuff is hard to test comprehensively, but the original report reproduced easily and is now fixed. I wasn't able to break anything by adding/editing/deleting comments.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- undoinline
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4974 Build 4992: [Placeholder Plan] Wait for 30 Seconds