Page MenuHomePhabricator
Create Task
Maniphest T7658

Deleting a draft inline comment and adding new inline comment moves the new comment to end of file.
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
shrinidhirao
Mar 25 2015, 5:06 AM
Tags
Referenced Files
F350177: inline_undo.JPG
Mar 25 2015, 5:06 AM
F350181: inline_undo_new_comment_end_of_file.JPG
Mar 25 2015, 5:06 AM
F350179: inline_undo_add_new.JPG
Mar 25 2015, 5:06 AM
Subscribers
chad
shrinidhirao

Description

Steps to reproduce the case:

  1. Add an inline comment and mark it 'ready'
  2. Delete the draft comment. You are prompted with 'Changes discarded. Undo'
  3. Do not undo. Add a new comment to the same line(s). Mark it ready again.
  4. The draft comment box jumps to the end of the current file.

inline_undo.JPG (216×744 px, 25 KB)

inline_undo_add_new.JPG (452×718 px, 40 KB)

inline_undo_new_comment_end_of_file.JPG (440×741 px, 42 KB)

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

shrinidhirao created this task.Mar 25 2015, 5:06 AM
shrinidhirao raised the priority of this task from to Needs Triage.
shrinidhirao updated the task description. (Show Details)
shrinidhirao added a subscriber: shrinidhirao.
chad added a subscriber: chad.Mar 25 2015, 5:12 AM

Just click undo? Haha

epriestley claimed this task.Mar 25 2015, 10:45 AM
epriestley added a project: Differential.
epriestley moved this task from Backlog to v2 (UI/Mobile) on the Differential board.
epriestley added a revision: Restricted Differential Revision.Mar 25 2015, 1:25 PM
epriestley triaged this task as Normal priority.Mar 25 2015, 1:26 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Mar 25 2015, 2:14 PM
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility