Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15391465
D12157.id29220.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D12157.id29220.diff
View Options
diff --git a/webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js b/webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js
--- a/webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js
+++ b/webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js
@@ -158,6 +158,12 @@
_didCompleteWorkflow : function(response) {
var op = this.getOperation();
+ // We don't get any markup back if the user deletes a comment, or saves
+ // an empty comment (which effects a delete).
+ if (response.markup) {
+ this._draw(JX.$H(response.markup).getNode());
+ }
+
if (op == 'delete' || op == 'refdelete') {
this._undoText = null;
this._drawUndo();
@@ -165,12 +171,6 @@
this._removeUndoLink();
}
- // We don't get any markup back if the user deletes a comment, or saves
- // an empty comment (which effects a delete).
- if (response.markup) {
- this._draw(JX.$H(response.markup).getNode());
- }
-
// These operations remove the old row (edit adds a new row first).
var remove_old = (op == 'edit' || op == 'delete' || op == 'refdelete');
if (remove_old) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 16, 10:02 AM (3 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7706807
Default Alt Text
D12157.id29220.diff (1 KB)
Attached To
Mode
D12157: Fix interaction between undo and inline comment placement
Attached
Detach File
Event Timeline
Log In to Comment