Page MenuHomePhabricator

Fix interaction between undo and inline comment placement
ClosedPublic

Authored by epriestley on Mar 25 2015, 1:25 PM.
Tags
None
Referenced Files
F15470522: D12157.id29220.diff
Fri, Apr 4, 11:14 PM
F15457227: D12157.diff
Sun, Mar 30, 3:05 PM
F15419196: D12157.diff
Fri, Mar 21, 4:25 AM
F15391465: D12157.id29220.diff
Sat, Mar 15, 10:02 AM
F15341078: D12157.id29221.diff
Sun, Mar 9, 6:33 PM
F15333104: D12157.diff
Mar 7 2025, 11:51 PM
Unknown Object (File)
Feb 8 2025, 3:12 AM
Unknown Object (File)
Feb 8 2025, 3:12 AM
Subscribers

Details

Summary

Fixes T7658. Currently, we remove the "undo" before placing the comment, but that causes us to lose track of which row we should be examining.

Instead, place the comment first, then remove the "undo".

Test Plan

This stuff is hard to test comprehensively, but the original report reproduced easily and is now fixed. I wasn't able to break anything by adding/editing/deleting comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix interaction between undo and inline comment placement.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Mar 25 2015, 1:47 PM
This revision was automatically updated to reflect the committed changes.