Page MenuHomePhabricator
Differential D12126

Publish draft "done" status when submitting comments/updates/actions/inlines
ClosedPublic
Actions

Authored by epriestley on Mar 21 2015, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:54 PM
Unknown Object (File)
Thu, Apr 25, 3:11 AM
Unknown Object (File)
Tue, Apr 16, 8:10 PM
Unknown Object (File)
Tue, Apr 16, 8:10 PM
Unknown Object (File)
Tue, Apr 16, 7:46 PM
Unknown Object (File)
Tue, Apr 16, 6:22 PM
Unknown Object (File)
Tue, Apr 9, 7:03 PM
Unknown Object (File)
Tue, Apr 9, 8:40 AM
View All Files
Subscribers
epriestley
yelirekim

Details

Reviewers
btrahan
Maniphest Tasks
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rP9f3210c883b9: Publish draft "done" status when submitting comments/updates/actions/inlines
Summary

Ref T1460. When a revision author updates/comments/etc on a revision, publish all their checkmarks.

This doesn't handle Diffusion/audits yet.

Test Plan

Screen_Shot_2015-03-21_at_10.50.11_AM.png (298×622 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Branch
uni39
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4940
Build 4958: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29152.Mar 21 2015, 5:50 PM
epriestley retitled this revision from to Publish draft "done" status when submitting comments/updates/actions/inlines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1460: Add "Done" link to an inline comment.
Herald added subscribers: epriestley, yelirekim. · View Herald TranscriptMar 21 2015, 5:50 PM
epriestley mentioned this in D12128: Publish "done" inline comment checkbox state in Diffusion.Mar 22 2015, 1:03 PM
btrahan accepted this revision.Mar 23 2015, 5:02 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 23 2015, 5:02 PM
Closed by commit rP9f3210c883b9: Publish draft "done" status when submitting comments/updates/actions/inlines (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2015, 12:27 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rPcbb5a297d57b: Publish "done" inline comment checkbox state in Diffusion.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
61 lines
storage/
39 lines
infrastructure/
diff/
query/
20 lines
internationalization/
translation/
32 lines

Diff 29152

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility