HomePhabricator

Track a "Done" state on inline comments

Authored by epriestley.

Description

Track a "Done" state on inline comments

Summary:
Ref T1460. This just barely works, but throwing it up in case any of it sounds mechanically crazy before we build integrations/UI/etc.

Specifically, these are the behaviors:

  • You can mark your own draft comments as "done" before you submit them. The intent is to let reviewers mark their stuff advisory/minor/not-important before they submit it, to hint to authors that they don't expect the feedback to necessarily be addressed (maybe it's a joke, maybe it's just discussion, maybe it's "consider..").
  • You can mark others' published comments as "done" if you're the revision/commit author. The intent is to keep this lightweight by not requiring an audit trail of who marked what done when. If anyone could mark anything done, we'd have to have some way to show who marked stuff.
  • When you mark stuff done (or unmark it), it goes into a "draft" state, where you see the change but others don't see it yet. The intent is twofold:
    • Be consistent with how inlines work.
    • Allow us to publish a "epriestley updated this revision + epriestley marked 15 inlines as done" story later if we want. This seems more useful than publishing 15 "epriestley marked one thing as done" stories.
  • The actual bit where done-ness publishes isn't implemented.
  • UI is bare bones.
  • No integration with the rest of the UI yet.

Test Plan: Clicked some checkboxes.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: paulshen, chasemp, epriestley

Maniphest Tasks: T1460

Differential Revision: https://secure.phabricator.com/D12033

Details

Committed
epriestleyMar 24 2015, 12:26 PM
Pushed
epriestleyMar 24 2015, 12:27 PM
Reviewer
btrahan
Differential Revision
D12033: Track a "Done" state on inline comments
Parents
rPd0b3f199bb71: Provide a smoother "update diff" web workflow
Branches
Unknown
Tags
Unknown
Tasks
T1460: Add "Done" link to an inline comment