Differential D12088

Examine fewer daemons for variant config
ClosedPublic
Actions

Authored by epriestley on Mar 14 2015, 8:59 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPbc28b2c3a809: Examine fewer daemons for variant config

Summary

Right now, if a daemon dies it can leave the setup warning around for like 10 minutes or something until we reap it.

Tighten the warning so we only care about actively running daemons.

Test Plan

Checked setup issues.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29075.Mar 14 2015, 8:59 PM

epriestley retitled this revision from to Examine fewer daemons for variant config.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 14 2015, 8:59 PM

btrahan accepted this revision.Mar 15 2015, 6:03 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 15 2015, 6:03 PM

Closed by commit rPbc28b2c3a809: Examine fewer daemons for variant config (authored by epriestley, committed by epriestley). · Explain WhyMar 15 2015, 6:31 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T7835: After hard non-graceful shutdown, Phabricator insists old daemons are still running..Apr 16 2015, 2:18 PM

epriestley mentioned this in D17397: Be less strict when detecting dead daemons.Feb 22 2017, 10:09 PM

epriestley mentioned this in rP939fb69aa68b: Be less strict when detecting dead daemons.Feb 22 2017, 10:11 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorDaemonsSetupCheck.php

2 lines

daemon/

query/

PhabricatorDaemonLogQuery.php

5 lines

Diff 29076

View Options

src/applications/config/check/PhabricatorDaemonsSetupCheck.php